codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Private Loadbalancers Whitelist #447

Closed aballman closed 5 years ago

aballman commented 5 years ago

Allows Private/Office type loadbalancers to augment their whitelisted IP ranges

codecov[bot] commented 5 years ago

Codecov Report

Merging #447 into master will decrease coverage by 0.01%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   58.04%   58.03%   -0.02%     
==========================================
  Files          56       56              
  Lines        5759     5767       +8     
==========================================
+ Hits         3343     3347       +4     
- Misses       2076     2080       +4     
  Partials      340      340

drshrey commented 5 years ago

@aballman looks good, can we add tests for this?

aballman commented 5 years ago

@aballman looks good, can we add tests for this?

@drshrey No, not really. I've added the artifact here just to increase the test coverage so it's not decreasing the coverage. But testing load balancers / services isn't totally possible.