codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Patch: change genDBUser func to have 14 chars #462

Closed drshrey closed 5 years ago

drshrey commented 5 years ago

Change the genDBUser func to have 10 chars and only use the uuid chars.

Improvement: A longer term fix is to allow variable lengths depending on the DB extension's artifact and use that as input when generating the function.

drshrey commented 5 years ago

Currently, we cannot install mysql DBs because the max username character length for mysql is 16 characters.

codecov[bot] commented 5 years ago

Codecov Report

Merging #462 into master will decrease coverage by 0.06%. The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
- Coverage   57.94%   57.87%   -0.07%     
==========================================
  Files          59       59              
  Lines        6173     6175       +2     
==========================================
- Hits         3577     3574       -3     
- Misses       2211     2215       +4     
- Partials      385      386       +1