codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO
Apache License 2.0
21 stars 6 forks source link

Scheduled Build Releaser #475

Closed aballman closed 5 years ago

aballman commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #475 into master will decrease coverage by 0.18%. The diff coverage is 47.22%.

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage    57.6%   57.41%   -0.19%     
==========================================
  Files          62       63       +1     
  Lines        6737     6806      +69     
==========================================
+ Hits         3881     3908      +27     
- Misses       2422     2459      +37     
- Partials      434      439       +5
amoskyler commented 5 years ago

Understood.

On Thu, May 23, 2019, 16:14 Andrew Ballman notifications@github.com wrote:

@aballman commented on this pull request.

In plugins/codeamp/codeamp.go https://github.com/codeamp/circuit/pull/475#discussion_r287166770:

    "websocket",
  • "project",
  • "release",
  • "^project",

This is a regex, so the ^ is an anchor to match only strings where this is the very beginning of the text. It was matching my "scheduledbranchreleaser" messages because it has release in it so i changed it to ^release

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/codeamp/circuit/pull/475?email_source=notifications&email_token=ABI4VRLNJWN7PT6FLX3AOKLPW4QLPA5CNFSM4HNYQWB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZSOELQ#discussion_r287166770, or mute the thread https://github.com/notifications/unsubscribe-auth/ABI4VRNGXTF2A4VFVK4FJMLPW4QLPANCNFSM4HNYQWBQ .