codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

S3 Plugin Creates Buckets #477

Closed aballman closed 5 years ago

aballman commented 5 years ago

Previously the S3 plugin used a pre-allocated bucket and then created permissions based on prefixes to slice up the bucket for other projects to share. This is inappropriate for some projects and they require a full bucket, such as in the case of ActiveRecord with its default settings. These changes modify the plugins behavior to create new buckets.

codecov[bot] commented 5 years ago

Codecov Report

Merging #477 into master will increase coverage by 0.08%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   57.49%   57.57%   +0.08%     
==========================================
  Files          62       62              
  Lines        6632     6737     +105     
==========================================
+ Hits         3813     3879      +66     
- Misses       2394     2424      +30     
- Partials      425      434       +9