davechan813 commented 5 years ago

Try to fix #490. Changed functions signatures to pass/return two strings. Added the project name as one of the label for Redis deployment and pods.

dave-chen% kubectl get pods -n test --show-labels 
NAME                                              READY   STATUS    RESTARTS   AGE   LABELS
developmen-codeamp-pa-efbbde49-5998bdcc8b-wss9h   1/1     Running   0          15m   app=developmen-codeamp-pa-efbbde49,pod-template-hash=5998bdcc8b,projectName=codeamp-panel

dave-chen% kubectl get deploy -n test --show-labels 
NAME                             READY   UP-TO-DATE   AVAILABLE   AGE   LABELS
developmen-codeamp-pa-efbbde49   1/1     1            1           14m   app=developmen-codeamp-pa-efbbde49,projectName=codeamp-panel

codecov[bot] commented 5 years ago

Codecov Report

Merging #491 into master will increase coverage by 0.08%. The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   50.48%   50.57%   +0.08%     
==========================================
  Files          74       74              
  Lines        8378     8384       +6     
==========================================
+ Hits         4230     4240      +10     
+ Misses       3637     3633       -4     
  Partials      511      511

aballman commented 5 years ago

Is this the right PR @davechan813? I don't see the labels being updated, and there's a lot of updates to unrelated tests.

codeamp / circuit

Dave/labels in redis #491

Codecov Report