codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO

Apache License 2.0

21 stars 6 forks source link

Check for Pod Restarts On Deploy #494

Closed aballman closed 5 years ago

aballman commented 5 years ago

Pods can be "deployed" but be stuck in a crashing state.
Specifically happens when an application has passed the pod readiness check but then fails a liveness check and is then restarted after the application is marked as ready.
This affects the deployment process and prevents a roll back/forward to be processed until the timeout completes.

codecov[bot] commented 5 years ago

Codecov Report

Merging #494 into master will decrease coverage by 0.02%. The diff coverage is 20%.

@@            Coverage Diff            @@
##           master    #494      +/-   ##
=========================================
- Coverage   50.52%   50.5%   -0.03%     
=========================================
  Files          74      74              
  Lines        8384    8388       +4     
=========================================
  Hits         4236    4236              
- Misses       3637    3641       +4     
  Partials      511     511