search

codeamp / circuit

CodeAmp API. Built with Golang, GraphQL, GORM and Socket-IO
Apache License 2.0
21 stars 6 forks source link

Prevent deleting all services #520

Closed aballman closed 4 years ago

aballman commented 4 years ago

Prevent deleteServices mutation from deleting all services if no ID or invalid ID is provided

codecov[bot] commented 4 years ago

Codecov Report

Merging #520 into master will decrease coverage by 0.21%. The diff coverage is 9.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   50.11%   49.90%   -0.22%     
==========================================
  Files          75       75              
  Lines        8831     8863      +32     
==========================================
- Hits         4426     4423       -3     
- Misses       3847     3869      +22     
- Partials      558      571      +13
Impacted Files Coverage Δ
plugins/codeamp/graphql/service_mutation.go 73.33% <9.30%> (-10.77%) :arrow_down:
plugins/githubstatus/githubstatus.go 46.66% <0.00%> (+1.33%) :arrow_up:
...scheduledbranchreleaser/scheduledbranchreleaser.go 40.57% <0.00%> (+2.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0450853...a145305. Read the comment docs.

itsmeniko commented 4 years ago

looks good to me, but I do not have complete awareness of all the moving parts in the codeamp codebase. The changes included seem to address the bug we saw today, though! :tada: