codeamp / panel

CodeAmp Web Application. Built with React.js, GraphQL and Material-UI.
12 stars 7 forks source link

Projects for Everyone #253

Closed aballman closed 6 years ago

aballman commented 6 years ago
aballman commented 6 years ago

Depends on Circuit PR: https://github.com/codeamp/circuit/pull/325

aballman commented 6 years ago

Fixes #160

aballman commented 6 years ago

Partially fixes #173

drshrey commented 6 years ago

Should we have the package updates be a separate PR? This way, if anything does break, we can isolate the failure more efficiently. @aballman

aballman commented 6 years ago

Normally I would agree with the sentiment about splitting package updates from the rest of the pr. In this case it's a material ui icon package. It's pretty easy to tell if it's broken or not by examining the icons to ensure they render correctly. If it is broken, nothing stops functioning because its only icons.