search

codeamp / panel

CodeAmp Web Application. Built with React.js, GraphQL and Material-UI.
12 stars 7 forks source link

Make `Command` optional in service setting #272

Closed zhouzhuojie closed 5 years ago

zhouzhuojie commented 5 years ago

Is your feature request related to a problem? Please describe. The Command of a service should be optional. Right now it requires non-empty command. Sometimes the upstream docker image set a very specific docker CMD, and usually the users don't need to override. For example

image

Describe the solution you'd like https://github.com/codeamp/panel/blob/master/src/components/Project/Services/index.js#L295 Remove required

zhouzhuojie commented 5 years ago

@aballman

I figured that the graphql interface requires $command: String!, so it's still required. I will just copy long commands to the field for now.

image