codeamp / panel

CodeAmp Web Application. Built with React.js, GraphQL and Material-UI.
12 stars 7 forks source link

Show value even if empty string in Projects/Secrets #325

Closed drshrey closed 5 years ago

drshrey commented 5 years ago

Currently, we do not offer a way for users to change the value of a secret if the secret's value is empty. This is what we show: screen shot 2019-02-11 at 12 27 47 pm

We should still show the value-related component even if the secret value is an empty string. The rationale being:

although we should not allow empty strings to be submitted to the API, there isn't any consequence to show an empty value and associated operations to the user. We should allow the user to delete the secret even when the value is empty, for instance