codeandcoffeelb / codeandcoffeelb.github.io

The repo for the official website for Code and Coffee in Long Beach, CA. Made with jekyll.
http://www.codeandcoffeelb.org
12 stars 14 forks source link

fix(_includes): update navigation per Jekyll tutorial #109

Closed francisfuzz closed 4 years ago

francisfuzz commented 4 years ago

Closes https://github.com/codeandcoffeelb/codeandcoffeelb.github.io/issues/95.

Summary

👋 Hello, codeandcoffeelb! I know @karimamer is assigned to the original issue, so I'm happy to yield to their changes and you're more than welcome to close this out.

Approach

This is my take drawing from the approach recommended in https://jekyllrb.com/tutorials/navigation/:

I tested my changes locally by spinning up the Dockerfile defined in this repo to ensure what I've proposed is functional. Here's a motion picture, if it helps!

new-navigation-walkthrough

Next steps

Requesting review from @davidnuon as the maintainer of this organization (please correct me if I'm wrong 🙇 ). I've allowed edits from maintainers in the case there's anything you'd like to modify. I'm open to receive any feedback about my implementation––I'm not tied down to anything in particular. Ultimately, I'd just like to see Navigation fixed for your site! 😎