search

codeandcoffeelb / codeandcoffeelb.github.io

The repo for the official website for Code and Coffee in Long Beach, CA. Made with jekyll.
http://www.codeandcoffeelb.org
12 stars 14 forks source link

add a page for challenges #53

Closed karimamer closed 8 years ago

karimamer commented 8 years ago

closes #51 this pull requests adds a dynamic way of creating challenge pages

karimamer commented 8 years ago

@rogerhoward @davidnuon the content needs to be reviewed. page titles and the first challenge page

rogerhoward commented 8 years ago

I'll test this, but I'm not going to merge it until we have actual content.

karimamer commented 8 years ago

:+1:

rogerhoward commented 8 years ago

I think this is a good example of the issue i noted as "a branch should represent an atomic change" in our contributions guide discussion - if I merged this PR it'd end up posting incomplete content directly to the site. We could either pull the sample content out so the functionality is there but won't do anything yet, or add final content if we have some. I'm going to add content tonight to support this week's challenge, just wanted to note my thinking on this PR.

karimamer commented 8 years ago

agreed reference to the discussion #38

rogerhoward commented 8 years ago

After reviewing, this PR isn't ready for merge - page still needs cleanup, proper headers, some context. I'll work on this tonight.

karimamer commented 8 years ago

@rogerhoward that is what i thought. thanks for reviewing this i can add the changes if you don't have time

rogerhoward commented 8 years ago

I'm going ahead and merging this - thanks for your work!