codeandmedia / zola_easydocs_theme

An easy way to create docs for your project
https://easydocs.codeandmedia.com
MIT License
41 stars 19 forks source link

Blockquotes are not rendered #9

Closed rgreinho closed 2 years ago

rgreinho commented 2 years ago

The theme does not render blockquotes. They are simply indented.

https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#blockquotes=

c-git commented 2 years ago

Do you have an example that you can share where it doesn't work?

rgreinho commented 2 years ago

Nothing online yet, but I can share a snippet of what I am working on.

This markdown:

## Setup the local dev environment

> **REMARK: make sure to run the commands in the correct folder.**

Renders as:

image

To adjust it, I added this to the main.css file:

blockquote {
  border-left: #808080 8px solid;
  margin: 0;
  background-color: #dcdcdc;
  padding: 0 20px;
}

And now it looks like this:

image
c-git commented 2 years ago

I see thanks for sharing. I tried it on a plan site without this theme and it looked like the first picture as well. I found similar CSS on https://cssdeck.com/blog/six-ways-style-blockquotes/ to make it look like the second. Not sure there is another way to address this as I looked at the generated HTML and it does in fact put it in a block quote so it's just a CSS styling problem.

rgreinho commented 2 years ago

Maybe just adding the bloquote to the main.css to provide a default style then?

I can submit a PR with my snippet if that would help you. The colors match with the theme, but maybe we should provide sensible default values as variables. 🤔

c-git commented 2 years ago

Yeah maybe, I guess we'll see what @codeandmedia thinks once they weigh in on this.

codeandmedia commented 2 years ago

@rgreinho would love to see your PR, generally - yes, I defined all colors as vars to make easy any color customization, so if we need more colors - we can add another one as var too