codeandpepper / janush

Set up a modern codebase for cloud-native web app with authentication features by running one command
https://janush.dev
MIT License
14 stars 1 forks source link

refactor: changed ci workflow for janush.app #218

Closed OskarZaremba closed 2 years ago

OskarZaremba commented 2 years ago

What has been introduced:

What should be introduced in future:

There are still places especially in web-deploy job where one can introduce another custom actions to extract some logic form main.yml file making it even more readable.

hadrysm commented 2 years ago

I guess these pictures shouldn't be in the project. @przemyslaw-rzasa-cp removed them before they were published. At the moment they are on s3.

OskarZaremba commented 2 years ago

I guess these pictures shouldn't be in the project. @przemyslaw-rzasa-cp removed them before they were published. At the moment they are on s3.

I think you're right. I created my branch from main before @przemyslaw-rzasa introduced his changes with pictures on s3. Then I created pr and sorted out conflicts but there was no conflicts with these images hence they are still there. I will check it and eventually remove what is required.