search

codeandtheory / YCharts

YCharts is a graph library for Android.
Apache License 2.0
614 stars 57 forks source link

kavin's code #130

Closed Bunty-petiwala closed 1 year ago

kikoso commented 1 year ago

Hi @Bunty-petiwala . Can you elaborate on what this PR introduces?

KavinSethu commented 1 year ago

Yes , its for showing String values in the AXIS and also in the Label

On Mon, Aug 7, 2023 at 10:32 PM Deepak KK @.***> wrote:

@.**** commented on this pull request.

In YChartsLib/src/main/java/co/yml/charts/common/model/Point.kt https://github.com/yml-org/YCharts/pull/130#discussion_r1286164929:

@@ -11,6 +11,8 @@ package co.yml.charts.common.model data class Point( val x: Float, val y: Float,

  • val xLable: String? = "",

@KavinSethu https://github.com/KavinSethu Do we need extra label property here? Since we have an explicit method for overriding the same behavior

— Reply to this email directly, view it on GitHub https://github.com/yml-org/YCharts/pull/130#pullrequestreview-1565806048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI73HGE5WZROII5NYUIV4TLXUENSHANCNFSM6AAAAAA3GYR34M . You are receiving this because you were mentioned.Message ID: @.***>

-- Kavin Sethu Android Developer https://developer.android.com/index.html 8508860035

kikoso commented 1 year ago

@KavinSethu and @Bunty-petiwala , it is not clear to me what this PR is solving or fixing.

Can you please elaborate on who is pushing this and what is solving?

KavinSethu commented 1 year ago

Actually Me and Bunty are colleague, we are work in the line graph we need to customize some design and functionally of the YCharts

On Tue, Aug 8, 2023 at 10:51 AM Enrique López Mañas < @.***> wrote:

@KavinSethu https://github.com/KavinSethu and @Bunty-petiwala https://github.com/Bunty-petiwala , it is not clear to me what this PR is solving or fixing.

Can you please elaborate on who is pushing this and what is solving?

— Reply to this email directly, view it on GitHub https://github.com/yml-org/YCharts/pull/130#issuecomment-1668926272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI73HGDM4JANJYF2A5ANXYTXUHEFFANCNFSM6AAAAAA3GYR34M . You are receiving this because you were mentioned.Message ID: @.***>

-- Kavin Sethu Android Developer https://developer.android.com/index.html 8508860035

kikoso commented 1 year ago

Please, update your PR with a clear description of what this is adding.