Wrong version in starcraftver.h?

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Download and install latest patch from Blizzard, 1.6.1.0
2. Start an AI with a BWAPI.dll after r3959 where CheckVersion was included.

What is the expected output?
StarCraft starting normal and bot working.

What do you see instead?
* Error message displaying I have the wrong SC version and BWAPI uses "1.6.1".
* The functionality that is removed because of "if ( isCorrectVersion )" in 
DLLMain.cpp

What version of the product are you using? On what operating system?
StarCraft version 1.6.1.0
Windows 7

Please provide any additional information below.
I found that starcraftver.h sets the SC_VER_4 to 1 and not to 0. Have I missed 
to do something?
Bot works fine when I change SC_VER_4 to 0.

Original issue reported on code.google.com by senth.wa...@gmail.com on 25 Jan 2012 at 2:07

[GoogleCodeExporter]

It is 1.16.1 and that is the version BWAPI also specifies.

Are you sure you have the 1.16.1 patch? What is your locale?

By locale, I mean what Starcraft language and which region did you download 
Starcraft for (or are in)?

Other people on the IRC have not had this issue. Our Starcraft versions report 
using 1.16.1.1, I will drop the last 1 for compatibility purposes.

Original comment by AHeinerm on 25 Jan 2012 at 8:11

• Changed state: Started
• Added labels: Type-Defect, Priority-High, Component-Logic, Usability, Milestone-Release

[GoogleCodeExporter]

I downloaded the patch from: 
http://us.battle.net/support/en/article/starcraft-patch-information. When I 
start the game it says something like "This version is already patched." Not 
exactly these words, I'm in Linux at the moment so I cannot check the exact 
wording. In details it displays that the patch version is 1.6.1.0 and that my 
current is 1.6.1.0

The game was bought in Sweden, Europe and the game is in English. I have the 
English version of Windows 7 installed.

If it is not the locale that causes the bug, maybe it could be that you 
downloaded the game from battle.net? I installed the game from the CDs and 
patched it manually. I can try to download and re-install it and see if that 
works. I will be back tomorrow with results.

As you mentioned no-one else is having the problem, so the fault can be on my 
side.

Thanks for the fast support.

Original comment by senth.wa...@gmail.com on 25 Jan 2012 at 8:38

[GoogleCodeExporter]

I downloaded the game from battle.net, installed it, then patched it with the 
same patch. Now it says it is version 1.16.1.1.

At least someone who installs StarCraft from their CDs will know why they can't 
upgrade to .1 instead of .0 (last digit).

Original comment by senth.wa...@gmail.com on 27 Jan 2012 at 12:42

[GoogleCodeExporter]

Fixed in r4059.

Original comment by AHeinerm on 22 Feb 2012 at 9:51

• Changed state: Fixed