codebar / pairing-tool

The new paring tool
MIT License
4 stars 1 forks source link

Update to MUI 5 and remove Node SASS #41

Closed saljuama closed 2 years ago

saljuama commented 2 years ago

Context

After a few months of the project not being maintained, in an attempt to come back and do some house cleaning and NodeJS version update in github actions and in general, and also updating Node SASS because security vulnerabilities, turns out NodeSass 7 and NodeJS 18 on Linux is not compatible, so the last step of the pipeline, deploy to github pages is not working.

Housekeeping roadmap, because the intention from now on is to open this for more people to collaborate and the feedback that the project is a bit complex and not super friendly to new developers, the aim is also to simplify it a little bit and updated deprecated versions so people is not confused when browsing and searching for official documentations and tutorials

Description

  1. Update Material UI 4 to MUI 5
  2. Remove Node SASS and swap from SASS to CSS in JS
  3. Any other change specially behaviour is out of scope
saljuama commented 2 years ago

Options: A. Use CSS in JS from Material UI 4, so all the mixins could become programmable B. Bump also Material UI from 4 to MUI 5, this is bigger effort, but also CSS in JS becomes way more usable and readable, better in the long run C. Undo the mixins and convert scss to regular CSS files

Extra context: