search

codebar / tutorials

🗒 codebar's tutorials
http://tutorials.codebar.io/
258 stars 241 forks source link

dropping support for ie8 #339

Closed trevorah closed 7 years ago

trevorah commented 7 years ago

ie8 is the last supported version of internet explorer for windows xp. It's usage is 1%-4% depending on which site you ask.

At the moment, we teach $.each as the way to iterate through an array, and I'd rather have students know the built-in array functions. Dropping ie8 means we can update our material, which is what this pull request does.

Thoughts?

richardwestenra commented 7 years ago

Thanks Andy, this is great! 👌

Thoughts: On the one hand, this is the jQuery tutorial not the JS native Array method tutorial. On the other hand, you're 100% right, we should be teaching Array.prototype.forEach instead of $.each. While this section was probably originally intended to teach the jQuery method, I'm happy with this change.

I wonder whether we should include a section on advanced native Array/Object methods (e.g. map and reduce) at the end of tutorial 2, but that's a different topic.

trevorah commented 7 years ago

I totally agree with splitting things out later on, especially for introducing terms like "method" rather than just "function". It was a bit tricky to talk about forEach without mentioning methods.

Like you said though, we can always introduce that later.

trevorah commented 7 years ago

No problem!

On 23 Feb 2017, at 10:28, Richard Westenra notifications@github.com wrote:

Merged #339.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.