search

codebndr / Ariadne-Bootloader

A little less unfinished TFTP bootloader for Arduino Ethernet or Arduino with Ethernet Shield
codebender.cc
98 stars 37 forks source link

Support for Atmega 1284p and Wiznet W5200 / W5500 chips #27

Closed arjenhiemstra closed 8 years ago

arjenhiemstra commented 8 years ago

Needed support for these chips for my own project. Now finally had the time to integrate back into the original code. Have a look and see if you want to merge it, it has been tested to work with Atmega 328p w/ W5100, w/ W5200 and w/ W5500 and Atmega 1284p w/ W5200 and w/ W5500.

loathingKernel commented 8 years ago

Thank you for the pull request. This one has many changes and I am not familiar with W5200 or W5500 chips, so it will take me some time to test it but so far it looks really good and I definitely want to merge it.

per1234 commented 8 years ago

I'm very excited to see this change made to Ariadne. Thanks!

I realize this would be a lot of work at this point but it would be really nice if these changes were broken into two pull requests: Adding ATmega1284P support, and Adding W5200/W5500 support. This would make for a much nicer commit history.

arjenhiemstra commented 8 years ago

Cool, thanks for this reply. I can split the work into two PR's (the 1284p support is code wise not that heavy), let me see if I can find some time to do this somewhere this week.

arjenhiemstra commented 8 years ago

I will open a new PR with the proposed changes in two separate commits.

loathingKernel commented 8 years ago

Thanks! Also, if you don't mind, don't include any compiled binaries in the PR, as the size of them makes diffs unavailable on github.

arjenhiemstra commented 8 years ago

Ok, let met find out how to do that (i’m not a git expert)

On 9 mei 2016, at 10:11, Stelios Tsampas notifications@github.com wrote:

Thanks! Also, if you don't mind, don't include any compiled binaries in the PR, as the size of them makes diffs unavailable on github.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/codebendercc/Ariadne-Bootloader/pull/27#issuecomment-217801963

loathingKernel commented 8 years ago

Nevermind, I will clean it up after merging it. I do not want to lose commit history so I will do some cleanups with later commit.