codebox / moment-precise-range

A moment.js plugin to display human-readable date/time ranges
https://codebox.net/pages/moment-date-range-plugin
MIT License
150 stars 91 forks source link

i18n use monent relative time concept #1

Open Pliman opened 10 years ago

Pliman commented 10 years ago

Hello, it nice to find moment-precise-range, but it doesn't support i18n, so I added i18n support with monent relative time concept.

One thing not good is that, now 'a' will replace '1', eg. '1 month' -> 'a month' but moment did like this, make be it will change in the future, probably moment-precise-range with i18n support can still work.

Pliman commented 10 years ago

hm... I should change test as well, later.

Pliman commented 10 years ago

retrieved tests, ‘1 second’ and'xx seconds' now will be 'a few seconds' which comes from moment i18n file, I think this is not perfect.

jbrockmeyer commented 10 years ago

Hey, have you checked if "german (de)" is working for the i18n?

cmalard commented 6 years ago

Hi @Pliman and @codebox , happy new year :-)

I would have been interested by this PR, some years have passed, what's the status ? :-)

Pliman commented 6 years ago

Hi, @cmalard , the modified files conflicts with current version.

Conflicting files readable-range-test.js readable-range.js

Should fix the conficts based on current version, sometime.