search

codebox / moment-precise-range

A moment.js plugin to display human-readable date/time ranges
https://codebox.net/pages/moment-date-range-plugin
MIT License
150 stars 91 forks source link

missing information about minimum required moment.js version #19

Closed melo0187 closed 7 years ago

melo0187 commented 8 years ago

I was using moment.js 2.8.1 and including your plugin produced Uncaught TypeError: m2.utcOffset is not a function. This is because of the fact that utcOffset has been added to moment.js only in version 2.9.0.

So I was thinking that you might want to add this information as requirement to the README.md at least. Just my 2 cents =)

YacheLee commented 7 years ago

I encounter the same issue too.

codebox commented 7 years ago

I have added the dependency on moment >= 2.9 into the package.json file - thanks for pointing this out.