search

codebox / moment-precise-range

A moment.js plugin to display human-readable date/time ranges
https://codebox.net/pages/moment-date-range-plugin
MIT License
150 stars 91 forks source link

Npm node, with i18n support #4

Closed mtscout6 closed 8 years ago

mtscout6 commented 10 years ago

This brings in PR #1 as well as changes it to work on npm. In order to get it to work on the browser you could just use browserify, or web-pack. I have published it to npm, although I would be willing to transfer or add you to the ownership; whichever you prefer.

Offirmo commented 10 years ago

Hello @mtscout6 I tested your fork, and it displays "a few seconds" for seconds.

I thought the point of this module was to be precise ??

P.S. why don't you have issues enabled on your fork ?

mtscout6 commented 10 years ago

First, my concern that this library addressed was primarily around accuracy in years. I have not personally dealt with nor needed seconds precision. The i18n support was enticing, hence the reason I ran with that fork.

Second, I didn't realize that issues were not enabled till right now. Which I have promptly enabled.

I would love pull requests to make it better!

codebox commented 8 years ago

I have finally added this to npm under the name moment-precise-range-plugin so closing this pull request.