search

codebrew / backbone-rails

Easily use backbone.js with rails 3.1
MIT License
1.62k stars 255 forks source link

Upgrade ruby-ejs to 1.1.1 and (optionally) move dependencies to .gemspec #123

Closed dvgica closed 11 years ago

dvgica commented 12 years ago

I've upgraded the ruby-ejs dependency to 1.1.1 to allow use of Underscore-style escaped interpolation, i.e. <%- %>. This is included in the first commit.

The second commit moves the development dependencies from the Gemfile to the .gemspec, and ignores the Gemfile.lock, as recommended by Yehuda Katz here: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/.

The first commit should work on its own, but I think the second one is a good idea as well.

Comments welcome (this is my first pull request...). Thanks for your work on this gem.

joker1007 commented 12 years ago

I was going to pull request like this. I want this commit merged.

dgutov commented 12 years ago

+1, I want escaped interpolations.

edlebert commented 12 years ago

+1

ryanfitz commented 11 years ago

These changes were merged in here and here

Thanks for the fixes