search

codebrew / backbone-rails

Easily use backbone.js with rails 3.1
MIT License
1.61k stars 255 forks source link

Updating Backbone.js to v1.0.0 #154

Closed JohnRiv closed 10 years ago

JohnRiv commented 11 years ago

Includes version bump for Mocha gem so tests continue to pass.

This essentially fixes issue #153

solidcell commented 11 years ago

+1

andrei4002 commented 11 years ago

you should also fix backbone sync rails, because currently on bb 1.0, the sync overrides are broken

TomK32 commented 11 years ago

yep, sync override is borken.

andrei4002 commented 11 years ago

what about the paramRoot?

gotoAndBliss commented 11 years ago

+1

highbeats commented 11 years ago

+1

gabetax commented 11 years ago

@andrei4002 @TomK32 I have PR #140 open that covers the Backbone.sync wrapping for CSRF and paramRoot. I've been using it in production with no issues.

michaelcarter commented 11 years ago

+1

gotoAndBliss commented 11 years ago

Honestly, this break was a blessing in disguise. I've since removed the gem completely from my rails app and do it all from scratch. Works like a predictable charm now.

sbkok commented 11 years ago

+1

joshuaballoch commented 11 years ago

+1

alec-c4 commented 11 years ago

waiting for submission

westonplatter commented 11 years ago

In case anyone is looking for a Backbone 1.0.0 gem, I started one to mimic this project but also plan to have more robust JS testing for integrations testing future Backbone versions and jquery-rails. https://github.com/westonplatter/railsy_backbone.

pselle commented 10 years ago

:+1:

manusajith commented 10 years ago

The master branch is now updated with the latest version of Backbone and Underscore. Thanks all for the contributions.