Closed chris48s closed 4 years ago
Nice! Thank you so much for doing this! We would have eventually gotten to it..er..maybe.
But you fixed these, and now the Admin and "browsable API" are things of beauty. YAY!:
Agree that since this is probably the limit of "stuff" we'd be serving up as web pages, we don't really need a more elaborate setup for storage ATM.
@billglover - tagging you, just in case there's something I've missed or other setup/config considerations you might have. Would this be better made in your already existing PR, or are we fine merging this in separately?
YAY thank you @chris48s!! 🚀
Yey! 🚢
Let's get these merged. I'll take care of updating open PR for staging deployment separately as I need to figure out to deploy these.
Mashing the big, green button. 🚢 🚀
At the moment, the backend throws a 404 on any javascript or CSS files. This means the admin interface looks like this:
There is clearly intent to use make use of the admin backend e.g: https://github.com/codebuddies/backend/issues/84 . Enabling nginx to serve static assets makes it much more usable:
..which is nicer :)
In general, this is primarily an API project so the vast majority of production traffic will be serving JSON. Javascript and CSS is only likely to be served to a small handful of admin users so I'd propose this as a production setup. There's not really any point in spending time on a more elaborate solution like farming it out to a static object storage service (S3/Spaces/whatever) to optimise the 1% case.