Closed lpatmo closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
main@9f4a380
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage ? 83.70%
=======================================
Files ? 29
Lines ? 491
Branches ? 0
=======================================
Hits ? 411
Misses ? 80
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9f4a380...1038206. Read the comment docs.
I think a little context or instruction under each header is needed. None of those headers are intuitive to me as to content or information. Was this borrowed from something or from a standard?
In particular, I think it's important to have a checklist or a prompt for users around which issues are being addressed, which discussions have been had, and which requirements or stories were taken into account. Also any substantive changes in behavior from previous versions.
And as a side note - why was this never tagged for review? It is very hard to know when something needs feedback if it isn't requested for review.
Template for new PRs. Feedback welcome!