codebuddies / backend

CodeBuddies back-end
https://codebuddies.org
GNU General Public License v3.0
20 stars 25 forks source link

Update pull_request_template.md #159

Closed lpatmo closed 4 years ago

lpatmo commented 4 years ago

Background/Context

Updates the PR template! Context: discussion in https://github.com/codebuddies/backend/discussions/158#discussioncomment-54738

Before and After

Before: image

After: Something closer to this: image

Acknowledgments (optional)

@BethanyG for the updated draft

Other notes (optional)

N/A

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@9f7cb65). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage        ?   83.70%           
=======================================
  Files           ?       29           
  Lines           ?      491           
  Branches        ?        0           
=======================================
  Hits            ?      411           
  Misses          ?       80           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f7cb65...598f15c. Read the comment docs.

BethanyG commented 4 years ago

Gah. Apologies for the individual delete suggestions. The interface wouldn't let me do a multi-line suggestion there for some reason. The purpose of the re-ordering is to get at what I think might be the most "common" tasks. I also removed "enhancement". I think "enhancements" are more or less a feature, the only difference being the "size" -- i.e., the addition of code that doesn't specifically address a bug. My thinking is the fewer the categories, the easier it is to fill out.

lpatmo commented 4 years ago

Thanks @BethanyG for the feedback/commit suggestions!