Closed watchtheblur closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
main@ca44c1f
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage ? 83.78%
=======================================
Files ? 32
Lines ? 518
Branches ? 0
=======================================
Hits ? 434
Misses ? 84
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update ca44c1f...0574967. Read the comment docs.
@lpatmo - should we be merging this?
Yep! Thought I already did, sorry!
@lpatmo So I can't exactly revert this or it's associated change #81 -- but I should. This PR should not have been approved - it is missing tests!! So the next thing we need to make sure to do for this endpoint is add the tests in for this and for all other issues. I was distracted. But I won't be next time!!
lol, I didn't forget -- I honestly didn't think this PR needed tests, but then I looked up an example and it (kinda??) makes sense to me. I documented in https://github.com/codebuddies/backend/issues/179!
What type of PR is this? (check all applicable)
Context
Closes Issue #80
This should be merged in after #81
Other Related Tickets & Documents (as needed)
This relates to Issue #79
Implementation Details
Installed osprojects model by editing models.py, and installed app by adding osprojects to base.py. Ran migrations for osprojects
docker-compose run --rm app python ./manage.py makemigrations osprojects docker-compose run --rm app python ./manage.py migrate
New Libraries/Dependancies Introduced (Fill out as needed)
Any new migration files added?
Did you add tests?
Code added or changed without test coverage or good reason for exemption won't be approved.
Did you add documentation?