codebuddies / backend

CodeBuddies back-end
https://codebuddies.org
GNU General Public License v3.0
20 stars 25 forks source link

Issue 80 createmodel #170

Closed watchtheblur closed 4 years ago

watchtheblur commented 4 years ago

What type of PR is this? (check all applicable)

Context

Closes Issue #80

This should be merged in after #81

Other Related Tickets & Documents (as needed)

This relates to Issue #79

Implementation Details

Installed osprojects model by editing models.py, and installed app by adding osprojects to base.py. Ran migrations for osprojects

docker-compose run --rm app python ./manage.py makemigrations osprojects docker-compose run --rm app python ./manage.py migrate

New Libraries/Dependancies Introduced (Fill out as needed)

Any new migration files added?

Did you add tests?

Code added or changed without test coverage or good reason for exemption won't be approved.

Did you add documentation?

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ca44c1f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?       32           
  Lines           ?      518           
  Branches        ?        0           
=======================================
  Hits            ?      434           
  Misses          ?       84           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ca44c1f...0574967. Read the comment docs.

BethanyG commented 4 years ago

@lpatmo - should we be merging this?

lpatmo commented 4 years ago

Yep! Thought I already did, sorry!

BethanyG commented 4 years ago

@lpatmo So I can't exactly revert this or it's associated change #81 -- but I should. This PR should not have been approved - it is missing tests!! So the next thing we need to make sure to do for this endpoint is add the tests in for this and for all other issues. I was distracted. But I won't be next time!!

lpatmo commented 4 years ago

lol, I didn't forget -- I honestly didn't think this PR needed tests, but then I looked up an example and it (kinda??) makes sense to me. I documented in https://github.com/codebuddies/backend/issues/179!