lpatmo commented 4 years ago

What type of PR is this? (check all applicable)

[ ] 🐛 Bug Fix
[ ] ✨ Feature (e.g. API change, enhancement, addition, etc.)
[ ] ♻️ Refactor
[ ] 📝 Documentation
[ ] 🔖 Release
[x] 🚩 Other (concerning: tests)

Context

Tests the osprojects model we created! Two todos:

[x] Cleared up this issue: osprojects/tests.py::test_osprojects_model /usr/local/lib/python3.7/site-packages/django/db/models/fields/__init__.py:1363: RuntimeWarning: DateTimeField OSProjects.modified received a naive datetime (2020-05-31 00:00:00) while time zone support is active. RuntimeWarning) by using datetime.now() [ ] Add more asserts (maybe?)

Other Related Tickets & Documents (as needed)

179

Implementation Details

[x] Created a factories.py file to generate new osprojects [x] Tested that a newly created osproject had the relevant fields [x] Ran docker-compose run --rm app pytest and confirmed that tests passed

New Libraries/Dependancies Introduced (Fill out as needed)

N/A

If you have added libraries or other dependancies, please list them (and links to their repos) below:

[ ] I've updated requirements.txt

Any new migration files added?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed

Did you add tests?

Code added or changed without test coverage or good reason for exemption won't be approved.

Yes, but could use feedback on these tests!

[x] 👍 yes
[ ] 🙋 no, because I need help
[ ] 🙅 no, because they aren't needed

Did you add documentation?

[ ] 📜 readme.md
[ ] 📜 contributing.md
[ ] 📜 wiki entry
[ ] 🙋 I'd like someone to help write documentation, and will file a new issue for it
[x] 🙅 no documentation needed

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@649c0c1). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage        ?   82.21%           
=======================================
  Files           ?       34           
  Lines           ?      568           
  Branches        ?        0           
=======================================
  Hits            ?      467           
  Misses          ?      101           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 649c0c1...ce4153b. Read the comment docs.

lpatmo commented 3 years ago

Thank you for reviewing, @BethanyG!! Will merge this in... and as you said, revisit/update as we get more of the endpoint done.

codebuddies / backend

[Issue 179] Adding a test for the osprojects model #184