search

codebuddies / backend

CodeBuddies back-end
https://codebuddies.org
GNU General Public License v3.0
20 stars 25 forks source link

[User Registration][Testing] New Registration & Auth Flow Broke "Users" App Tests #192

Open BethanyG opened 3 years ago

BethanyG commented 3 years ago

The changes in PR #187 once merged will cause the tests under users/tests/ to mostly fail (6 out of 9).

Currently, these are marked skip, but need to be re-written to work (or the app needs to change to make them work).

Failing tests are:

 -   users/tests/test_models.py:7 test_user_get_absolute_url
 -   users/tests/test_urls.py:8 test_detail
 -   users/tests/test_urls.py:16 test_update
 -   users/tests/test_urls.py:21 test_redirect
 -   users/tests/test_views.py:19 TestUserUpdateView.test_get_success_url
 -   users/tests/test_views.py:43 TestUserRedirectView.test_get_redirect_url

Suspect they can mostly be fixed with some URL changes. Since the "users" app is largely unused due to DRF, these were seen as lower-priority tests, and I didn't hold #187 for them.

BethanyG commented 3 years ago

One overarching question here is do we even want this as an endpoint?? userauth has all of the registration flow and email verifications, should we just add to it for the user profile, or park that functionality here in users??

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

BethanyG commented 3 years ago

still open