search

codebuddies / cb-connect

Platform to connect mentors with mentees, accountability partners, and OS project maintainers with new contributors
GNU General Public License v3.0
14 stars 8 forks source link

Add CI #54

Closed angelocordon closed 5 years ago

angelocordon commented 5 years ago

This PR addresses issues #40 and #49 together. It includes configuring TravisCI to automatically run tests and check both for linting or code style violations when submitting a PR.

Additionally, it configures ESLint and Prettier together to apply StandardJS code formatting. NPM scripts are included to help address formatting errors.

https://github.com/codebuddies/cb-connect/blob/05fdfed943f9b270173d751a044edaebcee2e209/package.json#L9-L12

Note that Travis will not fix these issues to give contributors the chance to fix it themselves, however it will fail the build and the report can be seen to see what said issues are.

TODO:

angelocordon commented 5 years ago

Note that Travis will not fix this issues

The pretest script however will use Prettier to format the codebase before it runs ESLint, only so that we can get some more important errors to fix (i.e., unused vars vs missing semicolons). https://github.com/codebuddies/cb-connect/blob/05fdfed943f9b270173d751a044edaebcee2e209/package.json#L6

angelocordon commented 5 years ago

Setting state[blocked] as planning to merge #41 (after review) prior to merging PR into staging. Upcoming PRs are set to fix Travis failing checks.