search

codebuddies / cb-connect

Platform to connect mentors with mentees, accountability partners, and OS project maintainers with new contributors
GNU General Public License v3.0
14 stars 8 forks source link

Increment node version to >= 10.0.0 #61

Closed code4cake closed 5 years ago

code4cake commented 5 years ago

Addresses issue #58 by defining a minimum of version of node to the latest major version, instead of locking to a specific version (previously locked to 8.11.4)

angelocordon commented 5 years ago

Thanks for the PR @dantesolis -- just updated the description so we can refer to it at a later date or git logs 👍

angelocordon commented 5 years ago

@dantesolis Thanks so much for the PR, I'm getting into some interesting rabbit hole with how Meteor handles Node versioning. From what I'm reading, Meteor uses a certain version of Node based on Meteor's own current version. Basically, changing the engine value to >= 10.0.0 doesn't actually change Meteor's version of Node, however this will probably go into affect somewhere else...

The latest official version of Meteor is 1.8, with 1.9 on its way. Meteor 1.8 uses Node 8.15.1 and Meteor 1.9 is supposedly going to jump to Node 10.

https://github.com/meteor/meteor-feature-requests/issues/342 https://github.com/meteor/meteor/pull/10527

I think I was using Meteor 1.6 before, which was using Node 8.11.xx. You can update your version of Meteor by running meteor update in your terminal and it should bump Node to the latest version compatible with that version of Meteor.

All this said, it seems like we might not be able to jump to Node 10 so easily after all, at least until Meteor 1.9 is out and stable. If anything, perhaps we should change the engine version to >= 8.11.4 so that we can make sure that Node gets set elsewhere (for example, setting Node in Travis should probably match this as well in this upcoming PR #54)

https://github.com/codebuddies/cb-connect/blob/16e909cc9b197b33dd4ace7339ded5087a453b2c/.travis.yml#L5-L6

I'm also guessing our dev packages are relying on or tied to this specific version of Node as well in some form.

angelocordon commented 5 years ago

Hey @dantesolis - thanks for bringing up this issue. I think I'm going to make the call and close this for now as I think Meteor just runs its own version of Node and what's on the package.json file is fine. Feel free to reopen #58 if we want further discussions around it.

code4cake commented 5 years ago

@angelocordon hey sorry just now seeing the message. Let me start "watching" the project, to keep in sync with messages.