codebuddies / frontend

Frontend concept with React for CBv3
https://cbv3.netlify.app
GNU General Public License v3.0
20 stars 27 forks source link

feat: Added Pagination to the Resources Page #166

Closed pdotsani closed 4 years ago

pdotsani commented 4 years ago

What type of PR is this? (check all applicable)

Context

Closes issue #104

Screenshots/Recordings (if there are UI changes)

Screen Shot 2020-10-17 at 10 01 51 AM

Implementation Details - what was your thought process as you changed the code?

Added tests?

Added to documentation (readme.md or contributing.md)?

lpatmo commented 4 years ago

YAY thank you for putting up this draft, @pdotsani! Do you need help getting the merge conflicts fixed?

Separately, I'll tag this as hacktoberfest-accepted in case you'd like the credit.

lpatmo commented 4 years ago

Also, I won't review this until this is out of draft mode.

pdotsani commented 4 years ago

@lpatmo Looks like a rebase fixed all the conflicts. Should be good for a review.

lpatmo commented 4 years ago

🎉 Functionality works and you've figured out how to work with https://material-ui.com/components/pagination/, which is great!

Left a few comments re: minor details like:

Thanks @pdotsani! Happy to discuss more in threads if you want to push back or have questions