`/welcome post [@<username>]` Triggers three messages.

codebuddies / greetbot

Slackbot for greeting new codebuddies users

MIT License

9 stars 14 forks source link

`/welcome post [@<username>]` Triggers three messages. #37

Open BethanyG opened 6 years ago

BethanyG commented 6 years ago

Again, suspect that the switch statement in /app/routes/endpoints/welcome/welcome.js is all jacked up. Typing /welcome post @username sends three messages to the user as a DM:

1) Two copies of the Welcome message 2) One copy of the help message

Going to recommend at this point that the switch statement be re-written to if-else, because the switch is producing unexpected results.

BethanyG commented 6 years ago

Assigning myself. There is a missing break; in the switch. ARG.

BethanyG commented 6 years ago

fixed with pull #38