Fixed double post issues #36 and #37 by adding break statements to Switch

codebuddies / greetbot

Slackbot for greeting new codebuddies users

MIT License

9 stars 14 forks source link

Fixed double post issues #36 and #37 by adding break statements to Switch #38

Closed BethanyG closed 6 years ago

BethanyG commented 6 years ago

This should fix issues #36 and #37. The switch statement in /routes/endpoints/slash/welcome/welcome.js was missing break; after each condition. This was causing fall-through to the case below. In addition, changed the switch condition to better reflect the data being sent in, so that the first case (two messages) only triggers if there are two unique target_Ids or channels.

BethanyG commented 6 years ago

This branch has been deployed to Glitch for review. Feel free to message me to revert the environment when done with the review.