search

codebuddies / greetbot

Slackbot for greeting new codebuddies users
MIT License
9 stars 14 forks source link

Refactor Code to Separate Concerns #6

Closed BethanyG closed 6 years ago

BethanyG commented 6 years ago

The code needs to be refactored into a "proper" Express app. The three current files need to be broken down into the "usual" tree. Something like what's generated here:

https://expressjs.com/en/starter/generator.html

This is so changes/additions to routes don't conflict or break changes made to messages or message actions. Endpoints need to have their own files and their own associated assets. Assets need to be separated from actions, and the incoming message parsing logic needs to be in it's own file. Configuration files need to be made for Staging and Production respectively.

BethanyG commented 6 years ago

First pass of this is now in https://github.com/codebuddies/greetbot/pull/15. It will probably needs some additional work, but is more or less chunked out.