search

codebuddies / greetbot

Slackbot for greeting new codebuddies users
MIT License
9 stars 14 forks source link

When a new user joins, they get three welcome messages #63

Closed lpatmo closed 6 years ago

lpatmo commented 6 years ago

When a new user signs up, they'll see the "welcome" message fire thrice.

Some people want to report this as a bug.

lpatmo commented 6 years ago

I've created a new user and can verify that this happens.

stain88 commented 6 years ago

Is this a new user to codebuddies, or the greetbot slack? If codebuddies, I can't reproduce. If greetbot, it's probably because we've "duped" the bots for individual testing, so all of them fire.

BethanyG commented 6 years ago

Confirm that a new user to codebuddies.slack.com gets (in my case) two bot instances and two Welcome messages. This was after I invited the user via an email/link from the Slack interface. However @stain88 used the "self-invite" method (the [get your invite] button on the website) - and only received a single message on joining.

I removed the second bot configuration for codebuddies. With one bot, I am only getting one welcome message (unless I click the "how does this app work?" link in the welcome message -- then I get two.

Currently, this deactivates the /welcome functionality for the bot (the current configuration doesn't have / commands configured. However, this will be fixed when we deploy the completed /resources functionality.

Can someone re-test, and reconfirm? Thanks!

BethanyG commented 6 years ago

Tested and confirmed by sending invites to @angelocordon and @stain88. Since they are now only getting spammed once, I am going to close this as fixed for now.