codebuddies / greetbot

Slackbot for greeting new codebuddies users
MIT License
9 stars 14 forks source link

Add additional text to the welcome message #87

Closed lpatmo closed 6 years ago

lpatmo commented 6 years ago

@wuworkshop saw this neat message @billglover wrote to a new member on Slack:

If you have any questions about the community or the project or want to talk to an admin, feel free to ask about it in #codebuddies-meta. It’s where discussions related to our community happen.

Let's add it to the welcome message. Do any new contributors want to work on it?

BethanyG commented 6 years ago

Well -- that didn't go through. Please see the two attached screengrabs below. The verbiage he used was from the existing welcome messages - no edits required...unless we'd also like to add a note about API keys or other code changes??

screen shot 2018-06-27 at 1 40 44 pm screen shot 2018-06-27 at 1 40 44 pm

BethanyG commented 6 years ago

If so...proposals on wording?

lpatmo commented 6 years ago

Draft:

If you have any questions about the community or the project or want to talk to an admin, feel free to ask about it in #codebuddies-meta. It’s where discussions related to our community happen.

If you'd like to add a new integration to the Slack, please ask in the #codebuddies-meta channel as well! Because CodeBuddies is on a free plan, the number of new Slack apps we can integrate is limited, so we would need to choose our integrations wisely.

wuworkshop commented 6 years ago

@lpatmo I just now noticed you misunderstood the thing I said in the Slack conversation. Bill said:

When talking to people about denying requests for tokens/plugins I’ve asked them to treat them as features and raise a request for discussion.

And I suggested that we add something along those lines to this part of the Welcome message:

If you have any questions about the community or the project or want to talk to an admin, feel free to ask about it in #codebuddies-meta. It’s where discussions related to our community happen.

lpatmo commented 6 years ago

@wuworkshop Proof that I was truly sleep-deprived yesterday! Here's a revised draft:

If you have any questions about the community or the project or want to talk to an admin, feel free to ask about it in #codebuddies-meta. It’s where discussions related to our community happen. If you'd like to add a new integration to the Slack, please treat it as a feature and raise a request for discussion by filing a Github issue.

Something like that?

peoray commented 6 years ago

Okay, so I wanna do this but it seems no consensus has been reached on what the message should be?

wuworkshop commented 6 years ago

Hmm... 🤔 I think I actually prefer @lpatmo's first draft.

If you have any questions about the community or the project or want to talk to an admin, feel free to ask about it in #codebuddies-meta. It’s where discussions related to our community happen.

If you'd like to add a new integration to the Slack, please ask in the #codebuddies-meta channel as well! Because CodeBuddies is on a free plan, the number of new Slack apps we can integrate is limited, so we would need to choose our integrations wisely.

I think it makes more sense for the person to ask in the Slack first about Slack integrations.

lpatmo commented 6 years ago

Thanks @wuworkshop! @peoray Is that enough for you to get started? Let us know if you run into any questions.

peoray commented 6 years ago

@lpatmo Yeah, let me get started. Wish me luck, first OSS contribution :fearful:

peoray commented 6 years ago

Okay, so I' having issues as to how to set up locally. I get it that I have to fork this repo https://github.com/codebuddies/greetbot, then set it up locally, but no detailed instruction was given as to how to do this

stain88 commented 6 years ago

Have you been through the wiki? Which step did you get stuck at?

peoray commented 6 years ago

So I encountered an error on the events subscriptions stage. Seems like my URL didn't respond with the value of the challenge parameter.

After running the two commands given: npm run start:dev-server and npm run start:dev-tunnel in two separate instances of my terminal, I got some errors thrown at me

Also, my URL https://peoray.localtunnel.me/ shows a 404 page

peoray commented 6 years ago

For some reason, my changes are not working!

I included the new text but no change on the message displayed by the bot

stain88 commented 6 years ago

I'll have to defer to @BethanyG on how the welcome message actually works. But if you want, throw up a new Pull Request, and we can review what you've done