Closed RamonaFrickCH closed 1 year ago
I just came across the same issue. The fix https://github.com/codebude/QRCoder/issues/216 was correct back then. But in the meantime the definition of this field StrdBkgInf changed from optional to additional. That means it must only be delivered if the element is not empty. This can be looked up in the following documents: Current standard: https://www.paymentstandards.ch/dam/downloads/ig-qr-bill-en.pdf Changes from version 2.1 to 2.2: https://www.paymentstandards.ch/dam/downloads/documentation-of-changes-2.2-en.pdf
@codebude: There is a new bug, because a line break is currently always inserted after BillInformation. But this is only allowed if the field actually contains data. Please fix this, thank you.
In de Class PayloadGenerator.cs Line 1142 Please fix the Bug #399
// https://github.com/codebude/QRCoder/issues/399 - If BillInformation is empty, insert no linebreak SwissQrCodePayload += (!string.IsNullOrEmpty(additionalInformation.BillInformation) ? additionalInformation.BillInformation + br : string.Empty); //StrdBkgInf
Hi @RamonaFrickCH , hi @feis1 thanks for your valuable input and sorry for my really slow response time. I merged the bugfix and will release it soon with QRCoder 1.5.0.
I've seen that meanwhile the Swiss Payment Standard version 2.3 was released. Are you aware of any other breaking changes in 2.3 that might require bugfixes?
Discussed in https://github.com/codebude/QRCoder/discussions/398