Closed doggy8088 closed 3 months ago
I decided to pass colors as byte[] to keep the PngByteQRCode free from any Windows dependencies. By adding System.Drawing just for the Color-class we had a dependency that isn't available on all platforms/in all environments. This would add another layer of complexity - in the codebase as also on the documentation side.
You can see in the compatibility matrix, that PngByteQRCode is one of the few renderers that works on all platforms and I really want to keep this feature: https://github.com/codebude/QRCoder/wiki/Advanced-usage---QR-Code-renderers#2-overview-of-the-different-renderers
Type of issue
[ ] Bug
[x] Question (e.g. about handling/usage)
[ ] Request for new feature/improvement
Expected Behavior
In the
GetGraphic
method from theQRCoder.PngByteQRCode
class, thedarkColorRgba
and thelightColorRgba
usebyte[]
to represent RGBA color. I expected to use Color struct. It's much easier.Current Behavior
The
byte[]
is not convenient on the usage.Possible Solution (optional)
Provide pleomorphism that accept Color struct.
Your Environment