codebude / QRCoder

A pure C# Open Source QR Code implementation
MIT License
4.43k stars 1.08k forks source link

Eliminate use of LINQ within GetVersion #524

Closed Shane32 closed 1 month ago

Shane32 commented 1 month ago

Minor performance tweak to eliminate allocations within GetVersion (assuming no exception is thrown).

codebude commented 1 month ago

Do you plan any further performance optimizations? Otherwise I would release & push the current state as 1.5.2. All those performance optimization already done are worth a release :-)

Shane32 commented 1 month ago

If I have time, I'd like to:

I have nothing against releasing 1.5.2 at any time you wish -- the performance optimizations have no effect on the exposed API or its use, and any future performance enhancements will be minor in comparison.