codebude / QRCoder

A pure C# Open Source QR Code implementation
MIT License
4.43k stars 1.08k forks source link

Some Payload generators miss overriding EciMode and EccLevel #525

Closed codebude closed 1 month ago

codebude commented 1 month ago

Type of issue

[x] Enhancement

Expected Behavior

If a payload type needs a specific eci mode/ecc level/version it should override the respecting parameters in the PayloadGenerator base class. Thus users don't have to set these values manually. Unfortunately some payload generators weren't updated after this feature (encoding parameters via payload) was added. Namely these are:

Solution

Override respecting encoding properties in the payload generator classes.


If someone is willing to fix this, just send in a PR. Otherwise I'll pick up the topic as soon as I find some spare time.