codebutler / android-websockets

Bare minimum websockets (hybi13/RFC) client for Android
713 stars 494 forks source link

Thanks for code. Maybe you interested in proposed improvements: #10

Open igor-- opened 11 years ago

igor-- commented 11 years ago

instead of your method: byteArrayToLong()

codebutler commented 11 years ago

Thanks igor, would you be able to submit a pull request?

igor-- commented 11 years ago

Hi !

For me it was learning task. Really I make clone:

You free use the code as you want (MIT licence)

Please see attachment

Regards, Igor

On Tue, May 28, 2013 at 12:49 AM, Eric Butler notifications@github.comwrote:

Thanks igor, would you be able to submit a pull request?

— Reply to this email directly or view it on GitHubhttps://github.com/codebutler/android-websockets/issues/10#issuecomment-18515911 .

codebutler commented 11 years ago

Hi @igor--, your attachment appears to be missing? thanks.

igor-- commented 11 years ago

Opps,

In attachment was sources in zip file !

Seems the mail have some filters How I can send it ?

Or maybe really submit it as clone in github ?

Igor

On Tue, May 28, 2013 at 8:09 PM, Eric Butler notifications@github.comwrote:

Hi @igor-- https://github.com/igor--, your attachment appears to be missing? thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/codebutler/android-websockets/issues/10#issuecomment-18565053 .

codebutler commented 11 years ago

a pull request is definitely easiest for me, cheers. https://help.github.com/articles/creating-a-pull-request

On Tue, May 28, 2013 at 10:57 AM, igor-- notifications@github.com wrote:

Opps,

In attachment was sources in zip file !

Seems the mail have some filters How I can send it ?

Or maybe really submit it as clone in github ?

Igor

On Tue, May 28, 2013 at 8:09 PM, Eric Butler notifications@github.comwrote:

Hi @igor-- https://github.com/igor--, your attachment appears to be missing? thanks.

— Reply to this email directly or view it on GitHub< https://github.com/codebutler/android-websockets/issues/10#issuecomment-18565053>

.

— Reply to this email directly or view it on GitHubhttps://github.com/codebutler/android-websockets/issues/10#issuecomment-18568306 .

igor-- commented 11 years ago

Hi Eric !

I create new project and commit the sources, please see:

https://github.com/igor--/tinywebsocket

Regards, Igor

On Tue, May 28, 2013 at 9:01 PM, Eric Butler notifications@github.comwrote:

a pull request is definitely easiest for me, cheers. https://help.github.com/articles/creating-a-pull-request

On Tue, May 28, 2013 at 10:57 AM, igor-- notifications@github.com wrote:

Opps,

In attachment was sources in zip file !

Seems the mail have some filters How I can send it ?

Or maybe really submit it as clone in github ?

Igor

On Tue, May 28, 2013 at 8:09 PM, Eric Butler notifications@github.comwrote:

Hi @igor-- https://github.com/igor--, your attachment appears to be missing? thanks.

— Reply to this email directly or view it on GitHub<

https://github.com/codebutler/android-websockets/issues/10#issuecomment-18565053>

.

— Reply to this email directly or view it on GitHub< https://github.com/codebutler/android-websockets/issues/10#issuecomment-18568306>

.

— Reply to this email directly or view it on GitHubhttps://github.com/codebutler/android-websockets/issues/10#issuecomment-18568564 .

codebutler commented 11 years ago

Thanks! I'll look into integrating your work. I had considered removing the Android-specific code, I like the name "tinywebsockets".

igor-- commented 11 years ago

OK Thanks.

On Tue, May 28, 2013 at 9:54 PM, Eric Butler notifications@github.comwrote:

Thanks! I'll look into integrating your work. I had considered removing the Android-specific code, I like the name "tinywebsockets".

— Reply to this email directly or view it on GitHubhttps://github.com/codebutler/android-websockets/issues/10#issuecomment-18571924 .