search

codecasts / laravel-jwt

Dead simple, plug and play JWT API Authentication for Laravel (5.4+)
MIT License
234 stars 27 forks source link

Contributing guide #19

Closed flyingluscas closed 6 years ago

flyingluscas commented 6 years ago

Hi @hernandev, me again hehe, I think it would be very good if this project had a contributing guide so that other developers don't make the same mistake I did when I've opened the PR #18, sending to the master branch instead of develop, what you think?

hernandev commented 6 years ago

You can include a PR that adds a CONTRIBUTING.md on the root folder, but also, it should go to develop.

Only git flow can change the master branch directly.

hernandev commented 6 years ago

Thanks!

flyingluscas commented 6 years ago

Great! I'll prepare a new PR for this tomorrow :)

hernandev commented 6 years ago

Thanks

flyingluscas commented 6 years ago

@hernandev I think it would be a good idea to make develop as the main branch, that way new pull requests go directly to it, what you think?

hernandev commented 6 years ago

Included Hacktoberfest label on some issues and PR, so you can all enjoy the perks of the promotion, check more about it here: https://hacktoberfest.digitalocean.com/

hernandev commented 6 years ago

Actually that's not even needed anymore, just figured it out.

@flyingluscas making develop default branch has implications on gitflow command line, since it may detect wrongly the production branch as being develop, since it's the default one.

I've just find out I can change the base branch on pull requests so that's not even a problem anymore, I can just change the branch when it comes to the wrong one.

For now, thanks for the contributing guide.