search

codecasts / php-alpine

PHP APK Repository for Alpine Linux
https://github.com/codecasts/php-alpine
482 stars 58 forks source link

Fixed deprecation messages with apcu #148

Closed tobias-trozowski closed 2 years ago

tobias-trozowski commented 2 years ago

Description

bumped apcu to 5.1.21 to fix deprecation messages

Fixes

PHP Deprecated:  Return type of APCUIterator::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
PHP Deprecated:  Return type of APCUIterator::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
PHP Deprecated:  Return type of APCUIterator::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
PHP Deprecated:  Return type of APCUIterator::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
PHP Deprecated:  Return type of APCUIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

see https://github.com/krakjoe/apcu/issues/425

tobias-trozowski commented 2 years ago

@hernandev i dont want to bother you but is there any chance u got some time to review this?

hernandev commented 2 years ago

Sorry for not merging earlier, and really thank you

tobias-trozowski commented 2 years ago

@hernandev just discovered that the build failed due to a curl error "Could not resolve host: www.abisource.com" (see https://github.com/codecasts/php-alpine/actions/runs/1714884683).

can u re-run those failing builds? Thank you!