search

codecasts / spa-starter-kit

A highly opinionated starter kit for building Single Page Applications with Laravel and Vue.js
MIT License
913 stars 134 forks source link

JavaScript Style #74

Closed 58bits closed 7 years ago

58bits commented 7 years ago

Curious to know why the project isn't using the 'standard' eslint settings. There are Webpack options for linting that come ready to go with the Vuejs.org Webpack template starter (on which this project is based)...

https://github.com/vuejs-templates/webpack https://github.com/feross/standard/blob/master/RULES.md#javascript-standard-style

Dangling commas in particular are a PHP PSR recommendation I believe, but not usually found in JavaScript.

No strong feelings here, but curious nevertheless. ;-)

vinicius73 commented 7 years ago

The best person to answer this is @vedovelli I currently prefer JavaScript Standard

vedovelli commented 7 years ago

Personal preference and nothing else! =D

58bits commented 7 years ago

Okay - well just a thought - but if you're aiming this as a starter kit, for others to use, then you might consider changing to the default linter and coding style that comes with the Vuejs.org Webpack template, otherwise it's a fairly big task for anyone to update the coding style to match (they'll have to manually edit the JS to 'fix it up to' get the linter to pass for Webpack builds).