search

codecat / godot-tbloader

TrenchBroom Loader for Godot 4. (Alternative to Qodot)
MIT License
240 stars 30 forks source link

Update godot-cpp & add a more accessible scons command to readme #66

Closed krazyjakee closed 1 year ago

krazyjakee commented 1 year ago

This version fixes a crash with Godot 4 RC1

codecat commented 1 year ago

Which crash does it fix exactly? I already pushed the changes needed for RC1. Was there another crash?

Additionally, might wanna display both scons commands.

somebody1121 commented 1 year ago

Maybe it's because of this: https://github.com/godotengine/godot/pull/72926

That or because the version from the assets library it's still on 0.14

codecat commented 1 year ago

Yeah, but I don't see why that would cause a crash.

somebody1121 commented 1 year ago

Then more likely it's the outdated version of the assets library

krazyjakee commented 1 year ago

Sorry I'm late to the party. Could well be that you beat me to it @codecat . I could repurpose this PR to make the readme changes if you prefer?

codecat commented 1 year ago

Definitely, if you can update the PR that'd be great!

krazyjakee commented 1 year ago

I'll sort the readme in another PR at a later date