codecat / tm-better-chat

A better chat for Trackmania using Openplanet.
https://openplanet.dev/plugin/betterchat
22 stars 7 forks source link

Default game chat visible beneath #54

Closed Yeribot closed 1 year ago

Yeribot commented 1 year ago

Been using and enjoying for a while but as of a few weeks ago the game's default chat is visible behind the BC window. Have tried toggling plugin and reinstalling to no avail.

codecat commented 1 year ago

Is this on Pyplanet servers or on Nadeo servers?

codecat commented 1 year ago

I can't reproduce this myself on the TOTD server:

image

Yeribot commented 1 year ago

Had only been playing TOTD myself which is where I was experiencing it. Just tried on a pyplanet server and that produces a JSON string in the default chat (which does not happen on TOTD servers). In my image the most recent message was sent with BetterChat and the one before sent with default chat (BC plugin toggled off). image

codecat commented 1 year ago

Evo servers aren't PyPlanet, they're running their own EvoSC. The json string is expected, but it's not supposed to show the actual chat. I just tried Evo FS Beginner, and can't reproduce it here:

image

Pyplanet is the only exception because some Pyplanet plugins use their own Manialink chat (see https://github.com/PyPlanet/PyPlanet/issues/1109)

Yeribot commented 1 year ago

Completely reinstalled Openplanet and did a fresh BetterChat install from plugin manager. Seems to have fixed the issue. Thanks for your help anyway.

codecat commented 1 year ago

I wonder if you had some setting enabled that broke it 🤔 Glad you fixed it anyway!

codecat commented 1 year ago

Re-opening this because more people have been starting to report this happening. image

XertroV commented 1 year ago

Strihke reported this too -- looks exactly like above. Happens on all servers.

From a MM game: image

XertroV commented 1 year ago

Did some research with Strihke about why this was happening.

better chat filters for CHmsZoneOverlay::EHmsOverlayAdaptRatio::ShrinkToKeepRatio_OnlyWider, but Strihke had no overlays with this tag. All of his were ShrinkToKeepRatio.

The SortOrder of each of his overlays were as follows (the /stkr just means ShrinkToKeepRatio):

solo: (ix: SortOrder / m_AdaptRatio)
0: 1/shrikn to keep ratio
1: 4/stkr
2: 5/stkr
3: 5/stkr
4: 5/stkr
5: 12/stkr
6: 14/stkr
7: 16/stkr
8: 16/stkr

generic server: (ix: SortOrder / m_AdaptRatio)
0:2/stkr
1:3/stkr
2:3/stkr
3:3/stkr
4:3/stkr
5:4/stkr
6:5/stkr
7:5/stkr
8:5/stkr
9:12/stkr
10: 14/stkr
11: 16/stkr
12: 16/stkr
codecat commented 1 year ago

This is likely a result of Tweaker or Tweaker Preview. Admittedly, checking for this enum is not gonna be reliable in any meaningful way. Instead, I am now just using the current playground interface root, see: e3fd286fa247b72ca59c4467a3de8ab1358b914a

XertroV commented 1 year ago

Well, that was an elegant fix.