XXH static linking is very ugly

codecat / unet

Unified Lobby Networking library in C++, providing cross-play between Steam lobbies, Gog Galaxy lobbies, and Enet sockets.

MIT License

7 stars 1 forks source link

Closed codecat closed 5 years ago

codecat commented 5 years ago

We have some modifications in xxhash.cpp which are strange and hacky, but are seemingly necessary for static linkage.

For example:

#define XXH_STATIC_LINKING_ONLY
//TODO: Hack.. UGH
#ifdef WIN32
#undef WIN32
#endif
#include <Unet/xxhash.h>

We should get rid of this ugly code and replace it with the proper way to statically link xxhash code.