search

codecentric / helm-charts

A curated set of Helm charts brought to you by codecentric
Apache License 2.0
615 stars 604 forks source link

Keycloakx 2.5.0: nil pointer when serviceMonitor or extraServiceMonitor are enabled #792

Open acceptMyPR opened 1 week ago

acceptMyPR commented 1 week ago

Hello

❯ helm version
version.BuildInfo{Version:"v3.15.3", GitCommit:"3bb50bbbdd9c946ba9989fbe4fb4104766302a64", GitTreeState:"clean", GoVersion:"go1.22.5"}

helm v3.15.3 Chart version 2.5.0

When serviceMonitor or extraServiceMonitor are enabled, where are an error during templating manifests:

❯ helm template codecentric/keycloakx --version=2.5.0 --set serviceMonitor.enabled=true --debug
install.go:222: [debug] Original chart version: "2.5.0"
install.go:239: [debug] CHART PATH: /Users/user/Library/Caches/helm/repository/keycloakx-2.5.0.tgz

Error: template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http
helm.go:84: [debug] template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http
❯ 
❯ 
❯ helm template codecentric/keycloakx --version=2.5.0 --set extraServiceMonitor.enabled=true --debug
install.go:222: [debug] Original chart version: "2.5.0"
install.go:239: [debug] CHART PATH: /Users/user/Library/Caches/helm/repository/keycloakx-2.5.0.tgz

Error: template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http
helm.go:84: [debug] template: keycloakx/templates/servicemonitor.yaml:37:24: executing "keycloakx/templates/servicemonitor.yaml" at <.Values.http.internalScheme>: nil pointer evaluating interface {}.http

2.4.4 is ok:

❯ helm template codecentric/keycloakx --version=2.4.4 --set serviceMonitor.enabled=true --debug | head
install.go:222: [debug] Original chart version: "2.4.4"
install.go:239: [debug] CHART PATH: /Users/user/Library/Caches/helm/repository/keycloakx-2.4.4.tgz

---
# Source: keycloakx/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: release-name-keycloakx
  namespace: default
  labels:
    helm.sh/chart: keycloakx-2.4.4
    app.kubernetes.io/name: keycloakx

this line crashing helm template https://github.com/codecentric/helm-charts/blob/f34a98deb3227b5cac1843c9225d9c5e288324f1/charts/keycloakx/templates/servicemonitor.yaml#L37

FranckKe commented 1 week ago

https://github.com/codecentric/helm-charts/pull/791